Santhosh Janardhanan
de2d83092e
- Delete old Vite+Svelte frontend - Initialize new SvelteKit project with TypeScript - Configure Tailwind CSS v4 + DaisyUI - Implement JWT authentication with auto-refresh - Create login page with form validation (Zod) - Add protected route guards - Update Docker configuration for single-stage build - Add E2E tests with Playwright (6/11 passing) - Fix Svelte 5 reactivity with $state() runes Known issues: - 5 E2E tests failing (timing/async issues) - Token refresh implementation needs debugging - Validation error display timing
65 lines
2.4 KiB
JavaScript
65 lines
2.4 KiB
JavaScript
import { createRule } from '../utils/index.js';
|
|
export default createRule('no-reactive-literals', {
|
|
meta: {
|
|
docs: {
|
|
description: "don't assign literal values in reactive statements",
|
|
category: 'Best Practices',
|
|
recommended: true
|
|
},
|
|
hasSuggestions: true,
|
|
schema: [],
|
|
messages: {
|
|
noReactiveLiterals: `Do not assign literal values inside reactive statements unless absolutely necessary.`,
|
|
fixReactiveLiteral: `Move the literal out of the reactive statement into an assignment`
|
|
},
|
|
type: 'suggestion',
|
|
conditions: [
|
|
{
|
|
svelteVersions: ['3/4']
|
|
},
|
|
{
|
|
svelteVersions: ['5'],
|
|
runes: [false, 'undetermined']
|
|
}
|
|
]
|
|
},
|
|
create(context) {
|
|
return {
|
|
[`SvelteReactiveStatement > ExpressionStatement > AssignmentExpression:matches(${[
|
|
// $: foo = "foo";
|
|
// $: foo = 1;
|
|
`[right.type="Literal"]`,
|
|
// $: foo = [];
|
|
`[right.type="ArrayExpression"][right.elements.length=0]`,
|
|
// $: foo = {};
|
|
`[right.type="ObjectExpression"][right.properties.length=0]`
|
|
].join(',')})`](node) {
|
|
// Move upwards to include the entire reactive statement
|
|
const parent = node.parent?.parent;
|
|
if (!parent) {
|
|
return false;
|
|
}
|
|
const source = context.sourceCode;
|
|
return context.report({
|
|
node: parent,
|
|
loc: parent.loc,
|
|
messageId: 'noReactiveLiterals',
|
|
suggest: [
|
|
{
|
|
messageId: 'fixReactiveLiteral',
|
|
fix(fixer) {
|
|
return [
|
|
// Insert "let" + whatever was in there
|
|
fixer.insertTextBefore(parent, `let ${source.getText(node)}`),
|
|
// Remove the original reactive statement
|
|
fixer.remove(parent)
|
|
];
|
|
}
|
|
}
|
|
]
|
|
});
|
|
}
|
|
};
|
|
}
|
|
});
|