- Delete old Vite+Svelte frontend - Initialize new SvelteKit project with TypeScript - Configure Tailwind CSS v4 + DaisyUI - Implement JWT authentication with auto-refresh - Create login page with form validation (Zod) - Add protected route guards - Update Docker configuration for single-stage build - Add E2E tests with Playwright (6/11 passing) - Fix Svelte 5 reactivity with $state() runes Known issues: - 5 E2E tests failing (timing/async issues) - Token refresh implementation needs debugging - Validation error display timing
117 lines
5.1 KiB
JavaScript
117 lines
5.1 KiB
JavaScript
import { createRule } from '../utils/index.js';
|
|
import { findVariable, getNodeName } from '../utils/ast-utils.js';
|
|
import { getPropertyName } from '@eslint-community/eslint-utils';
|
|
const DOM_MANIPULATING_METHODS = new Set([
|
|
'appendChild', // https://developer.mozilla.org/en-US/docs/Web/API/Node/appendChild
|
|
'insertBefore', // https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore
|
|
'normalize', // https://developer.mozilla.org/en-US/docs/Web/API/Node/normalize
|
|
'removeChild', // https://developer.mozilla.org/en-US/docs/Web/API/Node/removeChild
|
|
'replaceChild', // https://developer.mozilla.org/en-US/docs/Web/API/Node/replaceChild
|
|
'after', // https://developer.mozilla.org/en-US/docs/Web/API/Element/after
|
|
'append', // https://developer.mozilla.org/en-US/docs/Web/API/Element/append
|
|
'before', // https://developer.mozilla.org/en-US/docs/Web/API/Element/before
|
|
'insertAdjacentElement', // https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentElement
|
|
'insertAdjacentHTML', // https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentHTML
|
|
'insertAdjacentText', // https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentText
|
|
'prepend', // https://developer.mozilla.org/en-US/docs/Web/API/Element/prepend
|
|
'remove', // https://developer.mozilla.org/en-US/docs/Web/API/Element/remove
|
|
'replaceChildren', // https://developer.mozilla.org/en-US/docs/Web/API/Element/replaceChildren
|
|
'replaceWith' // https://developer.mozilla.org/en-US/docs/Web/API/Element/replaceWith
|
|
]);
|
|
const DOM_MANIPULATING_PROPERTIES = new Set([
|
|
'textContent', // https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent
|
|
'innerHTML', // https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML
|
|
'outerHTML', // https://developer.mozilla.org/en-US/docs/Web/API/Element/outerHTML
|
|
'innerText', // https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/innerText
|
|
'outerText' // https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/outerText
|
|
]);
|
|
export default createRule('no-dom-manipulating', {
|
|
meta: {
|
|
docs: {
|
|
description: 'disallow DOM manipulating',
|
|
category: 'Possible Errors',
|
|
recommended: true
|
|
},
|
|
schema: [],
|
|
messages: {
|
|
disallowManipulateDOM: "Don't manipulate the DOM directly. The Svelte runtime can get confused if there is a difference between the actual DOM and the DOM expected by the Svelte runtime."
|
|
},
|
|
type: 'problem'
|
|
},
|
|
create(context) {
|
|
const domVariables = new Set();
|
|
/**
|
|
* Verify DOM variable identifier node
|
|
*/
|
|
function verifyIdentifier(node) {
|
|
const member = node.parent;
|
|
if (member?.type !== 'MemberExpression' || member.object !== node) {
|
|
return;
|
|
}
|
|
const name = getPropertyName(member);
|
|
if (!name) {
|
|
return;
|
|
}
|
|
let target = member;
|
|
let parent = target.parent;
|
|
while (parent?.type === 'ChainExpression') {
|
|
target = parent;
|
|
parent = parent.parent;
|
|
}
|
|
if (!parent) {
|
|
return;
|
|
}
|
|
if (parent.type === 'CallExpression') {
|
|
if (parent.callee !== target || !DOM_MANIPULATING_METHODS.has(name)) {
|
|
return;
|
|
}
|
|
}
|
|
else if (parent.type === 'AssignmentExpression') {
|
|
if (parent.left !== target || !DOM_MANIPULATING_PROPERTIES.has(name)) {
|
|
return;
|
|
}
|
|
}
|
|
else {
|
|
return;
|
|
}
|
|
context.report({
|
|
node: member,
|
|
messageId: 'disallowManipulateDOM'
|
|
});
|
|
}
|
|
return {
|
|
"SvelteDirective[kind='Binding']"(node) {
|
|
if (node.key.name.name !== 'this' ||
|
|
!node.expression ||
|
|
node.expression.type !== 'Identifier') {
|
|
// not bind:this={id}
|
|
return;
|
|
}
|
|
const element = node.parent.parent;
|
|
if (element.type !== 'SvelteElement' || !isHTMLElement(element)) {
|
|
// not HTML element
|
|
return;
|
|
}
|
|
const variable = findVariable(context, node.expression);
|
|
if (!variable || (variable.scope.type !== 'module' && variable.scope.type !== 'global')) {
|
|
return;
|
|
}
|
|
domVariables.add(variable);
|
|
},
|
|
'Program:exit'() {
|
|
for (const variable of domVariables) {
|
|
for (const reference of variable.references) {
|
|
verifyIdentifier(reference.identifier);
|
|
}
|
|
}
|
|
}
|
|
};
|
|
/**
|
|
* Checks whether the given node is a HTML element or not.
|
|
*/
|
|
function isHTMLElement(node) {
|
|
return (node.kind === 'html' || (node.kind === 'special' && getNodeName(node) === 'svelte:element'));
|
|
}
|
|
}
|
|
});
|