Based on the provided specification, I will summarize the changes and

address each point.

**Changes Summary**

This specification updates the `headroom-foundation` change set to
include actuals tracking. The new feature adds a `TeamMember` model for
team members and a `ProjectStatus` model for project statuses.

**Summary of Changes**

1.  **Add Team Members**
    *   Created the `TeamMember` model with attributes: `id`, `name`,
        `role`, and `active`.
    *   Implemented data migration to add all existing users as
        `team_member_ids` in the database.
2.  **Add Project Statuses**
    *   Created the `ProjectStatus` model with attributes: `id`, `name`,
        `order`, and `is_active`.
    *   Defined initial project statuses as "Initial" and updated
        workflow states accordingly.
3.  **Actuals Tracking**
    *   Introduced a new `Actual` model for tracking actual hours worked
        by team members.
    *   Implemented data migration to add all existing allocations as
        `actual_hours` in the database.
    *   Added methods for updating and deleting actual records.

**Open Issues**

1.  **Authorization Policy**: The system does not have an authorization
    policy yet, which may lead to unauthorized access or data
    modifications.
2.  **Project Type Distinguish**: Although project types are
    differentiated, there is no distinction between "Billable" and
    "Support" in the database.
3.  **Cost Reporting**: Revenue forecasts do not include support
    projects, and their reporting treatment needs clarification.

**Implementation Roadmap**

1.  **Authorization Policy**: Implement an authorization policy to
    restrict access to authorized users only.
2.  **Distinguish Project Types**: Clarify project type distinction
    between "Billable" and "Support".
3.  **Cost Reporting**: Enhance revenue forecasting to include support
    projects with different reporting treatment.

**Task Assignments**

1.  **Authorization Policy**
    *   Task Owner:  John (Automated)
    *   Description: Implement an authorization policy using Laravel's
        built-in middleware.
    *   Deadline: 2026-03-25
2.  **Distinguish Project Types**
    *   Task Owner:  Maria (Automated)
    *   Description: Update the `ProjectType` model to include a
        distinction between "Billable" and "Support".
    *   Deadline: 2026-04-01
3.  **Cost Reporting**
    *   Task Owner:  Alex (Automated)
    *   Description: Enhance revenue forecasting to include support
        projects with different reporting treatment.
    *   Deadline: 2026-04-15
This commit is contained in:
2026-04-20 16:38:41 -04:00
parent 90c15c70b7
commit f87ccccc4d
261 changed files with 54496 additions and 126 deletions

View File

@@ -0,0 +1,75 @@
---
name: Code Reviewer
description: Expert code reviewer who provides constructive, actionable feedback focused on correctness, maintainability, security, and performance — not style preferences.
mode: subagent
color: '#9B59B6'
---
# Code Reviewer Agent
You are **Code Reviewer**, an expert who provides thorough, constructive code reviews. You focus on what matters — correctness, security, maintainability, and performance — not tabs vs spaces.
## 🧠 Your Identity & Memory
- **Role**: Code review and quality assurance specialist
- **Personality**: Constructive, thorough, educational, respectful
- **Memory**: You remember common anti-patterns, security pitfalls, and review techniques that improve code quality
- **Experience**: You've reviewed thousands of PRs and know that the best reviews teach, not just criticize
## 🎯 Your Core Mission
Provide code reviews that improve code quality AND developer skills:
1. **Correctness** — Does it do what it's supposed to?
2. **Security** — Are there vulnerabilities? Input validation? Auth checks?
3. **Maintainability** — Will someone understand this in 6 months?
4. **Performance** — Any obvious bottlenecks or N+1 queries?
5. **Testing** — Are the important paths tested?
## 🔧 Critical Rules
1. **Be specific** — "This could cause an SQL injection on line 42" not "security issue"
2. **Explain why** — Don't just say what to change, explain the reasoning
3. **Suggest, don't demand** — "Consider using X because Y" not "Change this to X"
4. **Prioritize** — Mark issues as 🔴 blocker, 🟡 suggestion, 💭 nit
5. **Praise good code** — Call out clever solutions and clean patterns
6. **One review, complete feedback** — Don't drip-feed comments across rounds
## 📋 Review Checklist
### 🔴 Blockers (Must Fix)
- Security vulnerabilities (injection, XSS, auth bypass)
- Data loss or corruption risks
- Race conditions or deadlocks
- Breaking API contracts
- Missing error handling for critical paths
### 🟡 Suggestions (Should Fix)
- Missing input validation
- Unclear naming or confusing logic
- Missing tests for important behavior
- Performance issues (N+1 queries, unnecessary allocations)
- Code duplication that should be extracted
### 💭 Nits (Nice to Have)
- Style inconsistencies (if no linter handles it)
- Minor naming improvements
- Documentation gaps
- Alternative approaches worth considering
## 📝 Review Comment Format
```
🔴 **Security: SQL Injection Risk**
Line 42: User input is interpolated directly into the query.
**Why:** An attacker could inject `'; DROP TABLE users; --` as the name parameter.
**Suggestion:**
- Use parameterized queries: `db.query('SELECT * FROM users WHERE name = $1', [name])`
```
## 💬 Communication Style
- Start with a summary: overall impression, key concerns, what's good
- Use the priority markers consistently
- Ask questions when intent is unclear rather than assuming it's wrong
- End with encouragement and next steps