santhoshj/headroom
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(project): Complete Project Lifecycle capability with full TDD workflow

Browse Source 
- Implement ProjectController with CRUD, status transitions, estimate/forecast
- Add ProjectService with state machine validation
- Extract ProjectStatusService for reusable state machine logic
- Add ProjectPolicy for role-based authorization
- Create ProjectSeeder with test data
- Implement frontend project management UI with modal forms
- Add projectService API client
- Complete all 9 incomplete unit tests (ProjectModelTest, ProjectForecastTest, ProjectPolicyTest)
- Fix E2E test timing issues with loading state waits
- Add Scribe API documentation annotations
- Improve forecasted effort validation messages with detailed feedback

Test Results:
- Backend: 49 passed (182 assertions)
- Frontend Unit: 32 passed
- E2E: 134 passed (Chromium + Firefox)

Phase 3 Refactor:
- Extract ProjectStatusService for state machine
- Optimize project list query with status joins
- Improve forecasted effort validation messages

Phase 4 Document:
- Add Scribe annotations to ProjectController
- Generate API documentation
This commit is contained in:
Santhosh Janardhanan
2026-02-19 02:43:05 -05:00
parent 8f70e81d29
commit 8ed56c9f7c
19 changed files with 5126 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
backend/tests/Unit/Models/ProjectForecastTest.php
View File

@@ -2,10 +2,13 @@
namespace Tests\Unit\Models;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
use App\Models\Project;
use App\Models\ProjectStatus;
use App\Services\ProjectService;
use Database\Seeders\ProjectStatusSeeder;
use Database\Seeders\ProjectTypeSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
class ProjectForecastTest extends TestCase
{
@@ -14,16 +17,62 @@ class ProjectForecastTest extends TestCase
// 3.1.24 Unit test: Forecasted effort validation
public function test_forecasted_effort_validation()
{
$this->markTestIncomplete('3.1.24: Implement forecasted effort validation tests');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$service = app(ProjectService::class);
$status = ProjectStatus::firstOrFail();
$project = Project::factory()->create([
'status_id' => $status->id,
]);
$forecast = ['2026-01' => 20, '2026-02' => 30];
$updated = $service->setForecastedEffort($project, $forecast);
$this->assertSame($forecast, $updated->forecasted_effort);
}
public function test_forecasted_sum_must_equal_approved_estimate()
{
$this->markTestIncomplete('3.1.24: Test forecasted sum equals approved');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$service = app(ProjectService::class);
$status = ProjectStatus::firstOrFail();
$project = Project::factory()->create([
'status_id' => $status->id,
]);
$service->setApprovedEstimate($project, 100);
$forecast = ['2026-01' => 40, '2026-02' => 60];
$updated = $service->setForecastedEffort($project, $forecast);
$this->assertEquals(100, array_sum($updated->forecasted_effort));
}
public function test_forecasted_effort_tolerance()
{
$this->markTestIncomplete('3.1.24: Test 5% tolerance for forecasted effort');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$service = app(ProjectService::class);
$status = ProjectStatus::firstOrFail();
$project = Project::factory()->create([
'status_id' => $status->id,
]);
$service->setApprovedEstimate($project, 100);
$forecastWithinTolerance = ['2026-01' => 50, '2026-02' => 55];
$service->setForecastedEffort($project, $forecastWithinTolerance);
$this->assertEquals(105, array_sum($project->refresh()->forecasted_effort));
$forecastTooHigh = ['2026-01' => 60, '2026-02' => 50];
$this->expectException(\RuntimeException::class);
$service->setForecastedEffort($project, $forecastTooHigh);
}
}

46
backend/tests/Unit/Models/ProjectModelTest.php
View File

@@ -2,11 +2,15 @@
namespace Tests\Unit\Models;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
use App\Models\Project;
use App\Models\ProjectStatus;
use App\Models\ProjectType;
use App\Services\ProjectService;
use App\Services\ProjectStatusService;
use Database\Seeders\ProjectStatusSeeder;
use Database\Seeders\ProjectTypeSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
class ProjectModelTest extends TestCase
{
@@ -15,16 +19,48 @@ class ProjectModelTest extends TestCase
// 3.1.22 Unit test: Project status state machine
public function test_project_status_state_machine()
{
$this->markTestIncomplete('3.1.22: Implement project status state machine tests');
$statusService = app(ProjectStatusService::class);
$this->assertContains('SOW Approval', $statusService->getValidTransitions('Pre-sales'));
}
public function test_project_can_transition_to_valid_status()
{
$this->markTestIncomplete('3.1.22: Test valid status transitions');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$service = app(ProjectService::class);
$preSales = ProjectStatus::where('name', 'Pre-sales')->firstOrFail();
$sowApproval = ProjectStatus::where('name', 'SOW Approval')->firstOrFail();
$type = ProjectType::firstOrFail();
$project = Project::factory()->create([
'status_id' => $preSales->id,
'type_id' => $type->id,
]);
$updated = $service->transitionStatus($project, $sowApproval->id);
$this->assertSame($sowApproval->id, $updated->status_id);
$this->assertSame('SOW Approval', $updated->status->name);
}
public function test_project_cannot_transition_to_invalid_status()
{
$this->markTestIncomplete('3.1.22: Test invalid status transitions are rejected');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$service = app(ProjectService::class);
$preSales = ProjectStatus::where('name', 'Pre-sales')->firstOrFail();
$inProgress = ProjectStatus::where('name', 'In Progress')->firstOrFail();
$type = ProjectType::firstOrFail();
$project = Project::factory()->create([
'status_id' => $preSales->id,
'type_id' => $type->id,
]);
$this->expectException(\RuntimeException::class);
$service->transitionStatus($project, $inProgress->id);
}
}

40
backend/tests/Unit/Policies/ProjectPolicyTest.php
View File

@@ -2,10 +2,13 @@
namespace Tests\Unit\Policies;
use App\Models\Project;
use App\Models\User;
use App\Policies\ProjectPolicy;
use Database\Seeders\ProjectStatusSeeder;
use Database\Seeders\ProjectTypeSeeder;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase;
use App\Models\User;
use App\Models\Project;
class ProjectPolicyTest extends TestCase
{
@@ -14,16 +17,43 @@ class ProjectPolicyTest extends TestCase
// 3.1.23 Unit test: ProjectPolicy ownership checks
public function test_project_policy_authorization()
{
$this->markTestIncomplete('3.1.23: Implement ProjectPolicy authorization tests');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$policy = new ProjectPolicy;
$roles = ['developer', 'manager', 'superuser'];
foreach ($roles as $role) {
$user = User::factory()->create(['role' => $role]);
$project = Project::factory()->create();
$this->assertTrue($policy->viewAny($user));
$this->assertTrue($policy->view($user, $project));
}
}
public function test_superuser_can_manage_all_projects()
{
$this->markTestIncomplete('3.1.23: Test superuser full access');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$policy = new ProjectPolicy;
$user = User::factory()->create(['role' => 'superuser']);
$project = Project::factory()->create();
$this->assertTrue($policy->create($user));
$this->assertTrue($policy->update($user, $project));
$this->assertTrue($policy->delete($user, $project));
}
public function test_manager_can_edit_own_projects()
{
$this->markTestIncomplete('3.1.23: Test manager project ownership');
$this->seed([ProjectStatusSeeder::class, ProjectTypeSeeder::class]);
$policy = new ProjectPolicy;
$user = User::factory()->create(['role' => 'manager']);
$project = Project::factory()->create();
$this->assertTrue($policy->create($user));
$this->assertTrue($policy->update($user, $project));
$this->assertTrue($policy->delete($user, $project));
}
}