Refactoring, regression testing until Phase 1 end.
This commit is contained in:
@@ -0,0 +1,280 @@
|
||||
# Design: Page Migrations
|
||||
|
||||
## Migration Strategy
|
||||
|
||||
### Approach
|
||||
1. Create new page using layout components
|
||||
2. Add route (+page.svelte)
|
||||
3. Add page load function (+page.ts) for data fetching
|
||||
4. Integrate with existing API endpoints
|
||||
5. Test and verify
|
||||
6. Remove old components
|
||||
|
||||
---
|
||||
|
||||
## Team Members Page
|
||||
|
||||
### `src/routes/team-members/+page.svelte`
|
||||
```svelte
|
||||
<script lang="ts">
|
||||
import { onMount } from 'svelte';
|
||||
import PageHeader from '$lib/components/layout/PageHeader.svelte';
|
||||
import DataTable from '$lib/components/common/DataTable.svelte';
|
||||
import FilterBar from '$lib/components/common/FilterBar.svelte';
|
||||
import type { ColumnDef } from '@tanstack/svelte-table';
|
||||
import { Plus, Edit, UserX } from 'lucide-svelte';
|
||||
|
||||
interface TeamMember {
|
||||
id: string;
|
||||
name: string;
|
||||
role: string;
|
||||
hourlyRate: number;
|
||||
active: boolean;
|
||||
}
|
||||
|
||||
let data = $state<TeamMember[]>([]);
|
||||
let loading = $state(true);
|
||||
let search = $state('');
|
||||
let statusFilter = $state('all');
|
||||
|
||||
const columns: ColumnDef<TeamMember>[] = [
|
||||
{
|
||||
accessorKey: 'name',
|
||||
header: 'Name',
|
||||
cell: info => `<span class="font-medium">${info.getValue()}</span>`
|
||||
},
|
||||
{ accessorKey: 'role', header: 'Role' },
|
||||
{
|
||||
accessorKey: 'hourlyRate',
|
||||
header: 'Hourly Rate',
|
||||
cell: info => `$${info.getValue()}/hr`
|
||||
},
|
||||
{
|
||||
accessorKey: 'active',
|
||||
header: 'Status',
|
||||
cell: info => info.getValue()
|
||||
? '<span class="badge badge-success">Active</span>'
|
||||
: '<span class="badge badge-ghost">Inactive</span>'
|
||||
},
|
||||
];
|
||||
|
||||
onMount(async () => {
|
||||
// TODO: Replace with actual API call
|
||||
data = [
|
||||
{ id: '1', name: 'Alice Johnson', role: 'Frontend Dev', hourlyRate: 85, active: true },
|
||||
{ id: '2', name: 'Bob Smith', role: 'Backend Dev', hourlyRate: 90, active: true },
|
||||
];
|
||||
loading = false;
|
||||
});
|
||||
|
||||
$derived filteredData = data.filter(m => {
|
||||
const matchesSearch = m.name.toLowerCase().includes(search.toLowerCase());
|
||||
const matchesStatus = statusFilter === 'all' ||
|
||||
(statusFilter === 'active' && m.active) ||
|
||||
(statusFilter === 'inactive' && !m.active);
|
||||
return matchesSearch && matchesStatus;
|
||||
});
|
||||
|
||||
function handleCreate() {
|
||||
// TODO: Open create modal
|
||||
}
|
||||
|
||||
function handleRowClick(row: TeamMember) {
|
||||
// TODO: Open edit modal or navigate to detail
|
||||
}
|
||||
</script>
|
||||
|
||||
<svelte:head>
|
||||
<title>Team Members | Headroom</title>
|
||||
</svelte:head>
|
||||
|
||||
<PageHeader title="Team Members" description="Manage your team roster">
|
||||
<button class="btn btn-primary btn-sm gap-2" onclick={handleCreate}>
|
||||
<Plus size={16} />
|
||||
Add Member
|
||||
</button>
|
||||
</PageHeader>
|
||||
|
||||
<FilterBar
|
||||
searchValue={search}
|
||||
searchPlaceholder="Search team members..."
|
||||
onSearchChange={(v) => search = v}
|
||||
>
|
||||
<select class="select select-sm" bind:value={statusFilter}>
|
||||
<option value="all">All Status</option>
|
||||
<option value="active">Active</option>
|
||||
<option value="inactive">Inactive</option>
|
||||
</select>
|
||||
</FilterBar>
|
||||
|
||||
<DataTable
|
||||
data={filteredData}
|
||||
{columns}
|
||||
{loading}
|
||||
emptyTitle="No team members"
|
||||
emptyDescription="Add your first team member to get started."
|
||||
onRowClick={handleRowClick}
|
||||
/>
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Projects Page
|
||||
|
||||
### `src/routes/projects/+page.svelte`
|
||||
```svelte
|
||||
<script lang="ts">
|
||||
import { onMount } from 'svelte';
|
||||
import PageHeader from '$lib/components/layout/PageHeader.svelte';
|
||||
import DataTable from '$lib/components/common/DataTable.svelte';
|
||||
import FilterBar from '$lib/components/common/FilterBar.svelte';
|
||||
import type { ColumnDef } from '@tanstack/svelte-table';
|
||||
import { Plus } from 'lucide-svelte';
|
||||
|
||||
interface Project {
|
||||
id: string;
|
||||
code: string;
|
||||
title: string;
|
||||
status: string;
|
||||
type: string;
|
||||
}
|
||||
|
||||
let data = $state<Project[]>([]);
|
||||
let loading = $state(true);
|
||||
let search = $state('');
|
||||
let statusFilter = $state('all');
|
||||
let typeFilter = $state('all');
|
||||
|
||||
const statusColors: Record<string, string> = {
|
||||
'Estimate Requested': 'badge-info',
|
||||
'Estimate Approved': 'badge-success',
|
||||
'In Progress': 'badge-primary',
|
||||
'On Hold': 'badge-warning',
|
||||
'Completed': 'badge-ghost',
|
||||
};
|
||||
|
||||
const columns: ColumnDef<Project>[] = [
|
||||
{ accessorKey: 'code', header: 'Code' },
|
||||
{ accessorKey: 'title', header: 'Title' },
|
||||
{
|
||||
accessorKey: 'status',
|
||||
header: 'Status',
|
||||
cell: info => {
|
||||
const status = info.getValue() as string;
|
||||
const color = statusColors[status] || 'badge-ghost';
|
||||
return `<span class="badge ${color}">${status}</span>`;
|
||||
}
|
||||
},
|
||||
{ accessorKey: 'type', header: 'Type' },
|
||||
];
|
||||
|
||||
onMount(async () => {
|
||||
// TODO: Replace with actual API call
|
||||
data = [];
|
||||
loading = false;
|
||||
});
|
||||
|
||||
$derived filteredData = data.filter(p => {
|
||||
const matchesSearch = p.title.toLowerCase().includes(search.toLowerCase()) ||
|
||||
p.code.toLowerCase().includes(search.toLowerCase());
|
||||
const matchesStatus = statusFilter === 'all' || p.status === statusFilter;
|
||||
const matchesType = typeFilter === 'all' || p.type === typeFilter;
|
||||
return matchesSearch && matchesStatus && matchesType;
|
||||
});
|
||||
</script>
|
||||
|
||||
<svelte:head>
|
||||
<title>Projects | Headroom</title>
|
||||
</svelte:head>
|
||||
|
||||
<PageHeader title="Projects" description="Manage project lifecycle">
|
||||
<button class="btn btn-primary btn-sm gap-2">
|
||||
<Plus size={16} />
|
||||
New Project
|
||||
</button>
|
||||
</PageHeader>
|
||||
|
||||
<FilterBar
|
||||
searchValue={search}
|
||||
searchPlaceholder="Search projects..."
|
||||
onSearchChange={(v) => search = v}
|
||||
>
|
||||
<select class="select select-sm" bind:value={statusFilter}>
|
||||
<option value="all">All Status</option>
|
||||
<option value="Estimate Requested">Estimate Requested</option>
|
||||
<option value="In Progress">In Progress</option>
|
||||
<option value="On Hold">On Hold</option>
|
||||
<option value="Completed">Completed</option>
|
||||
</select>
|
||||
<select class="select select-sm" bind:value={typeFilter}>
|
||||
<option value="all">All Types</option>
|
||||
<option value="Project">Project</option>
|
||||
<option value="Support">Support</option>
|
||||
</select>
|
||||
</FilterBar>
|
||||
|
||||
<DataTable
|
||||
data={filteredData}
|
||||
{columns}
|
||||
{loading}
|
||||
emptyTitle="No projects"
|
||||
emptyDescription="Create your first project to get started."
|
||||
/>
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Placeholder Page Template
|
||||
|
||||
### `src/routes/actuals/+page.svelte`
|
||||
```svelte
|
||||
<script lang="ts">
|
||||
import PageHeader from '$lib/components/layout/PageHeader.svelte';
|
||||
import EmptyState from '$lib/components/common/EmptyState.svelte';
|
||||
import { Clock } from 'lucide-svelte';
|
||||
</script>
|
||||
|
||||
<svelte:head>
|
||||
<title>Actuals | Headroom</title>
|
||||
</svelte:head>
|
||||
|
||||
<PageHeader title="Actuals" description="Track logged hours">
|
||||
<!-- No actions yet -->
|
||||
</PageHeader>
|
||||
|
||||
<EmptyState
|
||||
title="Coming Soon"
|
||||
description="Actuals tracking will be available in a future update."
|
||||
icon={Clock}
|
||||
/>
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Routes to Create
|
||||
|
||||
| Route | Status | Description |
|
||||
|-------|--------|-------------|
|
||||
| `/team-members` | Full | DataTable with CRUD |
|
||||
| `/projects` | Full | DataTable with workflow |
|
||||
| `/allocations` | Placeholder | Coming soon |
|
||||
| `/actuals` | Placeholder | Coming soon |
|
||||
| `/reports/forecast` | Placeholder | Coming soon |
|
||||
| `/reports/utilization` | Placeholder | Coming soon |
|
||||
| `/reports/costs` | Placeholder | Coming soon |
|
||||
| `/reports/variance` | Placeholder | Coming soon |
|
||||
| `/reports/allocation` | Placeholder | Coming soon |
|
||||
| `/settings` | Placeholder | Coming soon (admin) |
|
||||
| `/master-data` | Placeholder | Coming soon (admin) |
|
||||
|
||||
---
|
||||
|
||||
## Cleanup Tasks
|
||||
|
||||
### Remove Old Components
|
||||
- Delete `src/lib/components/Navigation.svelte`
|
||||
- Update any remaining imports
|
||||
|
||||
### Update Root Layout
|
||||
- Ensure AppLayout is used for all authenticated pages
|
||||
- Remove any old navigation code
|
||||
@@ -0,0 +1,65 @@
|
||||
# Proposal: Page Migrations
|
||||
|
||||
## Overview
|
||||
Migrate existing pages to use the new layout system and content patterns, completing the UI refactor.
|
||||
|
||||
## Goals
|
||||
- Migrate Team Members page with DataTable
|
||||
- Migrate Projects page with status workflow
|
||||
- Create placeholder pages for remaining capabilities
|
||||
- Remove old Navigation component
|
||||
- Ensure all E2E tests pass
|
||||
|
||||
## Non-Goals
|
||||
- New functionality (just layout migration)
|
||||
- Backend API work
|
||||
|
||||
## Priority
|
||||
**MEDIUM** - Complete the UI refactor
|
||||
|
||||
## Scope
|
||||
|
||||
### Pages to Migrate
|
||||
1. **Team Members** (`/team-members`)
|
||||
- DataTable with CRUD
|
||||
- FilterBar with search and status filter
|
||||
- Inline edit or modal for create/edit
|
||||
|
||||
2. **Projects** (`/projects`)
|
||||
- DataTable with status badges
|
||||
- FilterBar with status/type filters
|
||||
- Status workflow indicators
|
||||
|
||||
3. **Allocations** (`/allocations`)
|
||||
- Allocation matrix view (new component)
|
||||
- Month navigation
|
||||
- Inline editing
|
||||
|
||||
### Placeholder Pages
|
||||
- `/actuals` - Basic page with coming soon
|
||||
- `/reports/*` - Basic pages with coming soon
|
||||
- `/settings` - Basic page for admin
|
||||
- `/master-data` - Basic page for admin
|
||||
|
||||
### Cleanup
|
||||
- Remove old `Navigation.svelte`
|
||||
- Update any remaining references
|
||||
|
||||
## Success Criteria
|
||||
- [ ] Team Members page migrated
|
||||
- [ ] Projects page migrated
|
||||
- [ ] Placeholder pages created
|
||||
- [ ] Old Navigation removed
|
||||
- [ ] All E2E tests pass
|
||||
- [ ] No console errors
|
||||
|
||||
## Estimated Effort
|
||||
4-6 hours
|
||||
|
||||
## Dependencies
|
||||
- p02-app-layout
|
||||
- p03-dashboard-enhancement
|
||||
- p04-content-patterns
|
||||
|
||||
## Blocks
|
||||
- None (final change in UI refactor sequence)
|
||||
105
openspec/changes/archive/2026-02-18-p05-page-migrations/tasks.md
Normal file
105
openspec/changes/archive/2026-02-18-p05-page-migrations/tasks.md
Normal file
@@ -0,0 +1,105 @@
|
||||
# Tasks: Page Migrations
|
||||
|
||||
## Phase 1: Team Members Page
|
||||
|
||||
### Create Route
|
||||
- [x] 5.1 Create `src/routes/team-members/` directory
|
||||
- [x] 5.2 Create `+page.svelte`
|
||||
- [x] 5.3 Create `+page.ts` for data loading (optional)
|
||||
|
||||
### Implement Page
|
||||
- [x] 5.4 Add PageHeader with title and Add button
|
||||
- [x] 5.5 Add FilterBar with search and status filter
|
||||
- [x] 5.6 Add DataTable with columns (Name, Role, Rate, Status)
|
||||
- [x] 5.7 Add status badge styling
|
||||
- [x] 5.8 Add loading state
|
||||
- [x] 5.9 Add empty state
|
||||
- [x] 5.10 Add row click handler (edit or navigate)
|
||||
- [x] 5.11 Add svelte:head with title
|
||||
|
||||
### Testing
|
||||
- [x] 5.12 Write E2E test: page renders
|
||||
- [x] 5.13 Write E2E test: search works
|
||||
- [x] 5.14 Write E2E test: filter works
|
||||
|
||||
## Phase 2: Projects Page
|
||||
|
||||
### Create Route
|
||||
- [x] 5.15 Create `src/routes/projects/` directory
|
||||
- [x] 5.16 Create `+page.svelte`
|
||||
- [x] 5.17 Create `+page.ts` for data loading (optional)
|
||||
|
||||
### Implement Page
|
||||
- [x] 5.18 Add PageHeader with title and New Project button
|
||||
- [x] 5.19 Add FilterBar with search, status, type filters
|
||||
- [x] 5.20 Add DataTable with columns (Code, Title, Status, Type)
|
||||
- [x] 5.21 Add status badge colors mapping
|
||||
- [x] 5.22 Add loading state
|
||||
- [x] 5.23 Add empty state
|
||||
- [x] 5.24 Add svelte:head with title
|
||||
|
||||
### Testing
|
||||
- [x] 5.25 Write E2E test: page renders
|
||||
- [x] 5.26 Write E2E test: search works
|
||||
- [x] 5.27 Write E2E test: status filter works
|
||||
|
||||
## Phase 3: Placeholder Pages
|
||||
|
||||
### Allocations
|
||||
- [x] 5.28 Create `src/routes/allocations/+page.svelte`
|
||||
- [x] 5.29 Add PageHeader
|
||||
- [x] 5.30 Add EmptyState with Coming Soon
|
||||
|
||||
### Actuals
|
||||
- [x] 5.31 Create `src/routes/actuals/+page.svelte`
|
||||
- [x] 5.32 Add PageHeader
|
||||
- [x] 5.33 Add EmptyState with Coming Soon
|
||||
|
||||
### Reports
|
||||
- [x] 5.34 Create `src/routes/reports/+layout.svelte` (optional wrapper)
|
||||
- [x] 5.35 Create `src/routes/reports/forecast/+page.svelte`
|
||||
- [x] 5.36 Create `src/routes/reports/utilization/+page.svelte`
|
||||
- [x] 5.37 Create `src/routes/reports/costs/+page.svelte`
|
||||
- [x] 5.38 Create `src/routes/reports/variance/+page.svelte`
|
||||
- [x] 5.39 Create `src/routes/reports/allocation/+page.svelte`
|
||||
- [x] 5.40 Add PageHeader and EmptyState to each
|
||||
|
||||
### Admin
|
||||
- [x] 5.41 Create `src/routes/settings/+page.svelte`
|
||||
- [x] 5.42 Create `src/routes/master-data/+page.svelte`
|
||||
- [x] 5.43 Add PageHeader and EmptyState to each
|
||||
|
||||
## Phase 4: Cleanup
|
||||
|
||||
- [x] 5.44 Remove `src/lib/components/Navigation.svelte`
|
||||
- [x] 5.45 Update any imports referencing old Navigation
|
||||
- [x] 5.46 Verify no broken imports
|
||||
- [x] 5.47 Remove any unused CSS from app.css
|
||||
|
||||
## Phase 5: E2E Test Updates
|
||||
|
||||
- [x] 5.48 Update auth E2E tests for new layout
|
||||
- [x] 5.49 Verify login redirects to dashboard
|
||||
- [x] 5.50 Verify dashboard has sidebar
|
||||
- [x] 5.51 Verify sidebar navigation works
|
||||
- [x] 5.52 Verify all new pages are accessible
|
||||
|
||||
## Phase 6: Verification
|
||||
|
||||
- [x] 5.53 Run `npm run check` - 1 error (pre-existing DataTable generics)
|
||||
- [x] 5.54 Run `npm run test:unit` - all tests pass
|
||||
- [x] 5.55 Run `npm run test:e2e` - all E2E tests pass
|
||||
- [x] 5.56 Manual test: All pages render correctly
|
||||
- [x] 5.57 Manual test: Navigation works
|
||||
- [x] 5.58 Manual test: No console errors
|
||||
|
||||
## Commits
|
||||
|
||||
1. `feat(pages): Create Team Members page with DataTable`
|
||||
2. `feat(pages): Create Projects page with status badges`
|
||||
3. `feat(pages): Create Allocations placeholder page`
|
||||
4. `feat(pages): Create Actuals placeholder page`
|
||||
5. `feat(pages): Create Reports placeholder pages`
|
||||
6. `feat(pages): Create Admin placeholder pages`
|
||||
7. `refactor: Remove old Navigation component`
|
||||
8. `test(e2e): Update E2E tests for new layout`
|
||||
Reference in New Issue
Block a user